New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Replace blocks with personal home page step #1237

Merged

SallyMcGrath merged 9 commits into main from replace-blocks-and-tweaks

Dec 10, 2024

Member

SallyMcGrath commented Dec 7, 2024 •

edited

Loading

What does this change?

replace cyf blocks with personal home page step
tweak step 0 to be a bit less police state
add links to dashboard throughout

Org Content?

ITD | Steps | 0-6

Checklist

I have read the contributing guidelines
I have checked my spelling and grammar with an automated tool
I have previewed my changes to check the markdown renders as I intend
I have run my code to check it works
My changes follow our Style Guide

Who needs to know about this?

SallyMcGrath added 6 commits

October 21, 2024 08:48


          replace scrimba with khan academy

aabe122

I have not replaced the next step yet - this is for people to look at and discuss.


          Merge branch 'main' into content/replace-scrimba

7a181d7


          Merge branch 'main' into content/replace-scrimba

c4b85c6


          Merge branch 'main' into content/replace-scrimba

ebda1e8


          tweak step 0 to be less police state

cdf27f4


          add php and bump everything else over

25da29c

Member Author

SallyMcGrath commented Dec 7, 2024

@cjyuan here's the content starter for php - edit away

SallyMcGrath added 2 commits

December 7, 2024 11:07


          formatting

aebb86a


          times are still weird

f64fa4a

Base automatically changed from content/replace-scrimba to main

December 7, 2024 13:59


          Merge branch 'main' into replace-blocks-and-tweaks

937e945

SallyMcGrath assigned cjyuan and SallyMcGrath

Member Author

SallyMcGrath commented Dec 7, 2024 •

edited

Loading

Oh actually I'll merge and then @cjyuan open a new PR with the changes as that is what we agreed last night!!

netlify bot commented Dec 7, 2024 •

edited

Loading

✅ Deploy Preview for cyf-curriculum canceled.

Name	Link
🔨 Latest commit	`937e945`
🔍 Latest deploy log	https://app.netlify.com/sites/cyf-curriculum/deploys/67545504c7fee70008eb14da

SallyMcGrath requested a review from cjyuan

December 7, 2024 14:02

netlify bot commented Dec 7, 2024 •

edited

Loading

✅ Deploy Preview for cyf-sdc ready!

Name	Link
🔨 Latest commit	`937e945`
🔍 Latest deploy log	https://app.netlify.com/sites/cyf-sdc/deploys/67545504ac9a3d0008715f5e
😎 Deploy Preview	https://deploy-preview-1237--cyf-sdc.netlify.app
📱 Preview on mobile	Toggle QR Code... Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

SallyMcGrath enabled auto-merge (squash)

December 7, 2024 14:02

netlify bot commented Dec 7, 2024 •

edited

Loading

✅ Deploy Preview for cyf-common ready!

Name	Link
🔨 Latest commit	`937e945`
🔍 Latest deploy log	https://app.netlify.com/sites/cyf-common/deploys/67545504db677e0008530f84
😎 Deploy Preview	https://deploy-preview-1237--cyf-common.netlify.app
📱 Preview on mobile	Toggle QR Code... Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

netlify bot commented Dec 7, 2024 •

edited

Loading

✅ Deploy Preview for cyf-programming ready!

Name	Link
🔨 Latest commit	`937e945`
🔍 Latest deploy log	https://app.netlify.com/sites/cyf-programming/deploys/675455043422f400080fe52f
😎 Deploy Preview	https://deploy-preview-1237--cyf-programming.netlify.app
📱 Preview on mobile	Toggle QR Code... Use your smartphone camera to open QR code link.
Lighthouse	1 paths audited Performance: 95 (🔴 down 4 from production) Accessibility: 100 (no change from production) Best Practices: 92 (no change from production) SEO: 90 (no change from production) PWA: - View the detailed breakdown and full score reports

To edit notification comments on pull requests, go to your Netlify site configuration.

netlify bot commented Dec 7, 2024 •

edited

Loading

✅ Deploy Preview for cyf-piscine ready!

Name	Link
🔨 Latest commit	`937e945`
🔍 Latest deploy log	https://app.netlify.com/sites/cyf-piscine/deploys/675455042c01e500084c52aa
😎 Deploy Preview	https://deploy-preview-1237--cyf-piscine.netlify.app
📱 Preview on mobile	Toggle QR Code... Use your smartphone camera to open QR code link.
Lighthouse	1 paths audited Performance: 85 (🔴 down 15 from production) Accessibility: 100 (no change from production) Best Practices: 92 (no change from production) SEO: 100 (no change from production) PWA: - View the detailed breakdown and full score reports

To edit notification comments on pull requests, go to your Netlify site configuration.

netlify bot commented Dec 7, 2024 •

edited

Loading

✅ Deploy Preview for cyf-itd ready!

Name	Link
🔨 Latest commit	`937e945`
🔍 Latest deploy log	https://app.netlify.com/sites/cyf-itd/deploys/67545504ca35e100081de4a8
😎 Deploy Preview	https://deploy-preview-1237--cyf-itd.netlify.app
📱 Preview on mobile	Toggle QR Code... Use your smartphone camera to open QR code link.
Lighthouse	1 paths audited Performance: 83 (🔴 down 2 from production) Accessibility: 100 (no change from production) Best Practices: 92 (no change from production) SEO: 100 (no change from production) PWA: - View the detailed breakdown and full score reports

To edit notification comments on pull requests, go to your Netlify site configuration.

netlify bot commented Dec 7, 2024 •

edited

Loading

✅ Deploy Preview for cyf-launch ready!

Name	Link
🔨 Latest commit	`937e945`
🔍 Latest deploy log	https://app.netlify.com/sites/cyf-launch/deploys/675455044466190008c7fb90
😎 Deploy Preview	https://deploy-preview-1237--cyf-launch.netlify.app
📱 Preview on mobile	Toggle QR Code... Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

netlify bot commented Dec 7, 2024 •

edited

Loading

✅ Deploy Preview for cyf-tracks ready!

Name	Link
🔨 Latest commit	`937e945`
🔍 Latest deploy log	https://app.netlify.com/sites/cyf-tracks/deploys/675455044466190008c7fb92
😎 Deploy Preview	https://deploy-preview-1237--cyf-tracks.netlify.app
📱 Preview on mobile	Toggle QR Code... Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Contributor

cjyuan commented Dec 7, 2024

To my understanding, these are the actions I need to take:

Approve this PR to acknowledge that I need to create a separate PR for the changes I am going to make in step 5.
Crate a new PR in the following manner: fork https://github.com/CodeYourFuture/curriculum/tree/main, make changes, and then submit a PR after I finished making changes.

Is that correct?

cjyuan approved these changes

View reviewed changes

Contributor

cjyuan left a comment

As requested

SallyMcGrath merged commit 9230bdb into main

34 checks passed

SallyMcGrath deleted the replace-blocks-and-tweaks branch

December 10, 2024 03:32

Ara225 mentioned this pull request

Step 0 - Move away from real name and photo #1242

Closed

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet